On Thu, Oct 24, 2019 at 08:34:26AM -0400, Liu Yi L wrote: [...] > +typedef struct VFIOIOMMUContext { > + VFIOContainer *container; > + IOMMUContext *iommu_ctx; > + IOMMUCTXNotifier n; > + QLIST_ENTRY(VFIOIOMMUContext) iommu_ctx_next; > +} VFIOIOMMUContext; > + No strong opinion on this - but for me it would be more meaningful to squash this patch into where this struct is firstly used. -- Peter Xu