On Tue, Oct 29, 2019 at 11:13:00AM +0100, Peter Zijlstra wrote:
> On Tue, Oct 29, 2019 at 03:11:04PM +0530, Saurav Girepunje wrote:
> > Use true/false for bool type "dbg" in mmu.c
> >
> > Signed-off-by: Saurav Girepunje <saurav.girepunje@xxxxxxxxx>
> > ---
> > arch/x86/kvm/mmu.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/arch/x86/kvm/mmu.c b/arch/x86/kvm/mmu.c
> > index 24c23c66b226..c0b1df69ce0f 100644
> > --- a/arch/x86/kvm/mmu.c
> > +++ b/arch/x86/kvm/mmu.c
> > @@ -68,7 +68,7 @@ enum {
> > #undef MMU_DEBUG
> >
> > #ifdef MMU_DEBUG
> > -static bool dbg = 0;
> > +static bool dbg = true;
>
> You're actually changing the value from false to true. Please, if you
> don't know C, don't touch things.
Hi,
Thanks for your review.
I accept that I have given wrong value "true" to debug variable. It's my bad my typo mistake.
I will make sure that I will not touch your exclusive C code where we can assign 0/1 to a bool variable,
As you have given me a free advice, I also request you to please don't review such small patches from newbie to discourage them.
Regards,
Saurav
