Re: [PATCH kvmtool] virtio: Ensure virt_queue is always initialised

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Oct 25, 2019 at 11:41:00AM +0100, Andre Przywara wrote:
> On Thu, 10 Oct 2019 15:28:52 +0100
> Will Deacon <will@xxxxxxxxxx> wrote:
> > Failing to initialise the virt_queue via virtio_init_device_vq() leaves,
> > amongst other things, the endianness unspecified. On arm/arm64 this
> > results in virtio_guest_to_host_uxx() treating the queue as big-endian
> > and trying to translate bogus addresses:
> > 
> >   Warning: unable to translate guest address 0x80b8249800000000 to host
> 
> Ouch, a user! ;-)
> 
> > Ensure the virt_queue is always initialised by the virtio device during
> > setup.
> 
> Indeed, this is also what the other virtio devices do.
> Confirmed to fix rng and balloon.
> 
> Thanks for spotting this!
> 
> Reviewed-by: Andre Przywara <andre.przywara@xxxxxxx>
> Tested-by: Andre Przywara <andre.przywara@xxxxxxx>

Cheers, Andre. Now pushed with your tags.

Will



[Index of Archives]     [KVM ARM]     [KVM ia64]     [KVM ppc]     [Virtualization Tools]     [Spice Development]     [Libvirt]     [Libvirt Users]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite Questions]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux