On Thu, Oct 24, 2019 at 12:54:31PM -0700, Jim Mattson wrote: > From: Ken Hofsass <hofsass@xxxxxxxxxx> > > A userspace agent can use cr3 to quickly determine whether a > KVM_EXIT_DEBUG is associated with a guest process of interest. > > KVM_CAP_DEBUG_EVENT_PDBR indicates support for the extension. Isn't PDBR x86-specific terminology? If we're going to use something that is x86-specific then just call it GUEST_CR3. If there's a chance that this is useful on other architectures then it'd probably be better to go with Linux's own terminology, e.g. KVM_CAP_DEBUG_EVENT_GUEST_PGD. > Signed-off-by: Ken Hofsass <hofsass@xxxxxxxxxx> > Signed-off-by: Jim Mattson <jmattson@xxxxxxxxxx> > Cc: Peter Shier <pshier@xxxxxxxxxx> > --- > v1 -> v2: Changed KVM_CAP_DEBUG_EVENT_PG_BASE_ADDR to KVM_CAP_DEBUG_EVENT_PDBR > Set debug.arch.cr3 in kvm_vcpu_do_singlestep and > kvm_vcpu_check_breakpoint > Added svm support Heh, I wonder what the record is for longest time between legitimate versions of a single patch.