On Tue, Oct 22, 2019 at 1:12 AM Like Xu <like.xu@xxxxxxxxxxxxxxx> wrote: > > The leagcy pmu_ops->msr_idx_to_pmc is only called in kvm_pmu_rdpmc, so > this name is restrictedly limited to rdpmc_idx which could be indexed > exactly to a kvm_pmc. Let's restrict its semantic by renaming the > existing msr_idx_to_pmc to rdpmc_idx_to_pmc, and is_valid_msr_idx to > is_valid_rdpmc_idx (likewise for kvm_pmu_is_valid_msr_idx). > > Suggested-by: Paolo Bonzini <pbonzini@xxxxxxxxxx> > Signed-off-by: Like Xu <like.xu@xxxxxxxxxxxxxxx> Nit: The ECX argument to RDPMC is more than just an index (in fact, intel_is_valid_msr_idx() extracts the index from the provided ECX value), so I'd suggest s/rdpmc_idx/rdpmc_ecx/g. Reviewed-by: Jim Mattson <jmattson@xxxxxxxxxx>
