On Mon, 21 Oct 2019, tglx wrote: >On Mon, 21 Oct 2019, Miaohe Lin wrote: >> If we reach here with r = 0, we will reassign r = 0 unnecesarry, then >> do the label set_irqchip_out work. >> If we reach here with r != 0, then we will do the label work directly. >> So this if statement and r = 0 assignment is redundant. > >Can you please get rid of that odd jump label completely? > > if (irqchip_kernel(kvm)) > r = kvm_vm_ioctl_set_irqchip(kvm, chip); > >Hmm? Sure, thanks for your reply. I will send patch v2 to complete it. Thanks again.