On 15/10/19 05:18, Sean Christopherson wrote: >> The KVM config option should be changed to a bool and its help text >> updated. Maybe something similar to the help for VIRTUALIZATION to make >> it clear that enabling KVM on its own does nothing. > Making KVM a bool doesn't work well, keeping it a tristate and keying off > KVM=y to force Intel or AMD (as done in the next patch) looks like the > cleanest implementation. Indeed, keeping the KVM option as tristate helps showing the right suboptions, similar to what Andrea did in patch 2. However, this patch already breaks the CONFIG_KVM_INTEL=y && CONFIG_KVM_AMD=y case I think, so it should be squashed with "KVM: monolithic: x86: disable linking vmx and svm at the same time into the kernel". > The help text should still be updated though. The patch doesn't change the fact that enabling KVM on its own does nothing, so the help text can be updated independently (patch welcome :)). Thanks, Paolo
