On Mon, Oct 14, 2019 at 12:37:39PM -0700, Jim Mattson wrote: > On Mon, Oct 14, 2019 at 12:15 PM Sean Christopherson > <sean.j.christopherson@xxxxxxxxx> wrote: > > > > On Mon, Oct 14, 2019 at 11:50:37AM -0700, Jim Mattson wrote: > > > NESTED_VMX_ENTER_NON_ROOT_MODE_STATUS_KVM_INTERNAL_ERROR? > > > > I can't tell if you're making fun of me for being pedantic about "Enter VMX", > > or if you really want to have a 57 character enum. :-) > > > > NESTED_VMENTER_? > > It's difficult to balance brevity and clarity. I have no problem with > 57 character enums, but I understand that Linux line-wrapping > conventions are designed for the VT100, so long enums present a > challenge. :-) Heh, the real problem is that I forgot what I was reading by the time I got to "STATUS". > How about: > > NVMX_VMENTRY_SUCCESS > NVMX_VMENTRY_VMFAIL > NVMX_VMENTRY_VMEXIT > NVMX_VMENTRY_INTERNAL_ERROR Works for me. Maybe NVMX_VMENTRY_KVM_INTERNAL_ERROR to be consistent?
