On 10/10/19 01:44, Jim Mattson wrote: >>> +uint32_t kvm_get_cpuid_max_basic(void) >>> +{ >>> + return kvm_get_supported_cpuid_entry(0)->eax; >>> +} >>> + >>> +uint32_t kvm_get_cpuid_max_extended(void) >> I would leave the existing function aside, and call this one >> kvm_get_cpuid_max_amd() since CPUID leaves at 0x80000000 are allocated >> by AMD. > The existing function *is* the one that gives the largest > AMD-allocated leaf. Sorry about that---my fault for snipping the patch and assuming some "git diff" craziness. > Note that Intel documents CPUID.80000000:EAX as > "Maximum Input Value for Extended Function CPUID Information," and AMD > documents this as "Largest extended function." Objection taken back, then! Paolo