On 10/10/19 09:30, Suleiman Souhlal wrote: > > Changes in v2: > - Move out of kvmclock and into its own clocksource and file. > - Remove timekeeping.c #ifdefs. > - Fix i386 build. This is now pretty clean, so my objections are more or less gone. I haven't put much thought into this, but are all fields of struct timekeeping necessary? Some of them are redundant with the existing wallclock MSRs. The handling of versioning probably varies depending on the exact set of fields, too. Paolo