On 26/09/19 16:35, Liran Alon wrote:
>
>
>> On 26 Sep 2019, at 17:32, Sean Christopherson <sean.j.christopherson@xxxxxxxxx> wrote:
>>
>> On Thu, Sep 26, 2019 at 11:24:57AM +0200, Paolo Bonzini wrote:
>>> On 25/09/19 03:18, Marc Orr wrote:
>>>> diff --git a/x86/unittests.cfg b/x86/unittests.cfg
>>>> index 694ee3d42f3a..05122cf91ea1 100644
>>>> --- a/x86/unittests.cfg
>>>> +++ b/x86/unittests.cfg
>>>> @@ -227,7 +227,7 @@ extra_params = -cpu qemu64,+umip
>>>>
>>>> [vmx]
>>>> file = vmx.flat
>>>> -extra_params = -cpu host,+vmx -append "-exit_monitor_from_l2_test -ept_access* -vmx_smp* -vmx_vmcs_shadow_test"
>>>> +extra_params = -cpu host,+vmx -append "-exit_monitor_from_l2_test -ept_access* -vmx_smp* -vmx_vmcs_shadow_test -atomic_switch_overflow_msrs_test"
>>>> arch = x86_64
>>>> groups = vmx
>>>
>>> I just noticed this, why is the test disabled by default?
>>
>> The negative test triggers undefined behavior, e.g. on bare metal the
>> test would fail because VM-Enter would succeed due to lack of an explicit
>> check on the MSR count.
>>
>> Since the test relies on somehwat arbitrary KVM behavior, we made it opt-in.
>
> Just note that when commit 5ac120c23753 ("x86: vmx: Test INIT processing during various CPU VMX states”)
> was merged to master, it was changed to accidentally remove “-atomic_switch_overflow_msrs_test”.
> (Probably a merge mistake).
>
> So this should be fixed by a new patch :P
I will just rewrite history and fix the mistake.
Paolo
