Re: [PATCH v2] KVM: LAPIC: Loose fluctuation filter for auto tune lapic_timer_advance_ns

[Wanpeng Li <kernellwp@xxxxxxxxx>]

On Thu, 26 Sep 2019 at 18:25, Paolo Bonzini <pbonzini@xxxxxxxxxx> wrote:
>
> On 26/09/19 02:54, Wanpeng Li wrote:
> > -#define LAPIC_TIMER_ADVANCE_ADJUST_MIN 100
> > -#define LAPIC_TIMER_ADVANCE_ADJUST_MAX 5000
> > -#define LAPIC_TIMER_ADVANCE_ADJUST_INIT 1000
> > +#define LAPIC_TIMER_ADVANCE_EXPIRE_MIN       100
> > +#define LAPIC_TIMER_ADVANCE_EXPIRE_MAX       10000
> > +#define LAPIC_TIMER_ADVANCE_NS_INIT  1000
> > +#define LAPIC_TIMER_ADVANCE_NS_MAX     5000
>
> I think the old #define value is good.  What about:
>
> -#define LAPIC_TIMER_ADVANCE_ADJUST_MIN 100
> -#define LAPIC_TIMER_ADVANCE_ADJUST_MAX 5000
> -#define LAPIC_TIMER_ADVANCE_ADJUST_INIT 1000
> +#define LAPIC_TIMER_ADVANCE_ADJUST_MIN 100     /* clock cycles */
> +#define LAPIC_TIMER_ADVANCE_ADJUST_MAX 10000   /* clock cycles */
> +#define LAPIC_TIMER_ADVANCE_NS_INIT    1000
> +#define LAPIC_TIMER_ADVANCE_NS_MAX     5000

Looks good, I guess you can update the patch during apply. :)

    Wanpeng