On 25/09/19 13:04, Sergio Lopez wrote:
> Yes, that would do the trick. There's another use of it at
> hw/intc/ioapic.c:78, but we should be safe as, at least in the case of
> Linux, DM_EXTINT is only used in check_timer(), which is only called if
> it detects a i8259 PIC.
Even there it is actually LVT0's DM_EXTINT, not the IOAPIC's. I think
pic_read_irq would have returned 7 (spurious IRQ on master i8259) until
commit 29bb5317cb ("i8259: QOM cleanups", 2013-04-29), so we should fix it.
Paolo
> We should probably add an assertion with an informative message, just in
> case.
Attachment:
signature.asc
Description: OpenPGP digital signature
