Re: [PATCH 0/3] Replace current->mm by kvm->mm on powerpc/kvm

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Sep 23, 2019 at 06:24:06PM -0300, Leonardo Bras wrote:
> By replacing, we would reduce the use of 'global' current on code,
> relying more in the contents of kvm struct.
> 
> On code, I found that in kvm_create_vm() there is:
> kvm->mm = current->mm;
> 
> And that on every kvm_*_ioctl we have tests like that:
> if (kvm->mm != current->mm)
>         return -EIO;
> 
> So this change would be safe.
> 
> I split the changes in 3 patches, so it would be easier to read
> and reject separated parts. If decided that squashing is better,
> I see no problem doing that.

The patch series looks fine.  It has missed the 5.4 merge window, and
it doesn't fix any bugs, so I will queue it up for the 5.5 merge
window, meaning that I will put it into my kvm-ppc-next branch when I
prepare it for the 5.5 merge window, probably in about a month from
now.

This remark also applies to your other patch "Reduce calls to get
current->mm by storing the value locally".

Thanks,
Paul.



[Index of Archives]     [KVM ARM]     [KVM ia64]     [KVM ppc]     [Virtualization Tools]     [Spice Development]     [Libvirt]     [Libvirt Users]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite Questions]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux