Re: [kvm-unit-tests PATCH 1/1] x86: setjmp: check expected value of "i" to give better feedback

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



+ Paolo Bonzini, Radim Krčmář, Marc Orr

On Thu, Sep 19, 2019 at 3:15 PM Bill Wendling <morbo@xxxxxxxxxx> wrote:
>
> Use a list of expected values instead of printing out numbers, which
> aren't very meaningful. This prints only if the expected and actual
> values differ.
>
> Signed-off-by: Bill Wendling <morbo@xxxxxxxxxx>
> ---
>  x86/setjmp.c | 23 +++++++++++++++--------
>  1 file changed, 15 insertions(+), 8 deletions(-)
>
> diff --git a/x86/setjmp.c b/x86/setjmp.c
> index 976a632..1874944 100644
> --- a/x86/setjmp.c
> +++ b/x86/setjmp.c
> @@ -1,19 +1,26 @@
>  #include "libcflat.h"
>  #include "setjmp.h"
>
> +static const int expected[] = {
> +       0, 1, 2, 3, 4, 5, 6, 7, 8, 9
> +};
> +
> +#define NUM_LONGJMPS ARRAY_SIZE(expected)
> +
>  int main(void)
>  {
> -    volatile int i;
> +    volatile int index = 0;
>      jmp_buf j;
> +    int i;
>
> -    if (setjmp(j) == 0) {
> -           i = 0;
> -    }
> -    printf("%d\n", i);
> -    if (++i < 10) {
> -           longjmp(j, 1);
> +    i = setjmp(j);
> +    if (expected[index] != i) {
> +           printf("FAIL: actual %d / expected %d\n", i, expected[index]);
> +           return -1;
>      }
> +    index++;
> +    if (i + 1 < NUM_LONGJMPS)
> +           longjmp(j, i + 1);
>
> -    printf("done\n");
>      return 0;
>  }
> --
> 2.23.0.351.gc4317032e6-goog
>




[Index of Archives]     [KVM ARM]     [KVM ia64]     [KVM ppc]     [Virtualization Tools]     [Spice Development]     [Libvirt]     [Libvirt Users]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite Questions]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux