> From: Zhang, Tina > Sent: Tuesday, September 3, 2019 9:27 AM > > Hi, > > Some people are asking whether the display refresh irq could be provided by > qemu vfio display? > > Some background: currently, we have two display timers. One is provided by > QEMU UI and the other one is provided by the vgpu. The vgpu display > framebuffer consumers (i.e. QEMU UIs) depend on the UI timer to consume > the contents in the vgpu display framebuffer, meanwhile the display > framebuffer producer (e.g. gvt-g display model) updates the framebuffer > content according to the vblank timer provided by gpu vendor driver. Since > these two timers are not synced, tearing could be noticed. > > So, theoretically to solve this tearing problem, we could have two options: > > Option 1: Like what we have in this patch set: stop the QEMU UI timer and let > both the framebuffer consumers and the framebuffer producer sync to the > display refresh event provided by vendor driver. So, QEMU UI can do the > refresh depending on this display refresh event to make sure to have a tear- > free framebuffer. > > Option 2: QEMU provides the emulated display refresh event to the vgpus > provided by vendor driver. For vgpus, the display refresh event can be > considered as the vblank event which is leveraged by guest window manager > to do the plane update or mode-setting. > > People are asking if option 2 could be a better choice. > I think the answer is specific to different usages. None is perfect in all scenarios. The key is to find out who is the primary display to show the guest framebuffer, then that guy is cared about tearing thus should be the source of vblank event: 1) Guest framebuffer is directly programmed to, and shown in the local display. In such case, the physical vblank event should be the source of virtual vblank event, i.e. kernel GVT-g driver should emulate the event in host vblank event handler. 2) Guest framebuffer is shown in the Qemu UI. Then, naturally Qemu UI should be the source of virtual vblank event, based on its own tearing requirement: a) Guest framebuffer is shown in the local application window, which is updated by the Qemu UI timer. Then virtual vblank should be sent at end of the UI timer handler, to make sure no change happened when the guest framebuffer is composited as the source texture. b) Qemu UI may program guest framebuffer directly to the physical plane, through whatever interface that kernel gfx driver provides. In such case, Qemu UI should wait for vblank notification from kernel, and then trigger the virtual vblank event. c) Qemu UI may further route the guest framebuffer to remote client, e.g. through vnc. Then virtual vblank event should be emulated according to tearing requirement in vnc protocol. 3) combination of 1) and 2), where either local display or Qemu UI is considered as primary display with the other for diagnostic purpose. Then the tearing of the primary display should drive the emulation of virtual vblank, while the other one may suffer from tearing issue. Accordingly, we may want a kernel interface allowing user space to specify the source of vblank emulation: in kernel or from user space. If the former is specified, then virtual vblank is driven by physical vblank event. Otherwise, user space should trigger the virtual vblank injection. Just leave all the decisions to user space. :-) Thanks Kevin
