* Michael S. Tsirkin (mst@xxxxxxxxxx) wrote: > - remove irqcontrol: user can enable interrupts by > writing command register directly Sorry if I gave you the impression that removing was needed. I actually think the irqcontrol was useful since it's atomic. > + gdev->info.name = "uio_pci_generic"; > + gdev->info.version = "0.01"; Minor nit: DRIVER_VERSION Otherwise, it looks good. thanks, -chris -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html