Re: [PATCHv3 RFC] uio: add generic driver for PCI 2.3 devices

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



* Michael S. Tsirkin (mst@xxxxxxxxxx) wrote:
> - remove irqcontrol: user can enable interrupts by
>   writing command register directly

Sorry if I gave you the impression that removing was needed.
I actually think the irqcontrol was useful since it's atomic.

> +	gdev->info.name = "uio_pci_generic";
> +	gdev->info.version = "0.01";

Minor nit: DRIVER_VERSION

Otherwise, it looks good.

thanks,

-chris
--
To unsubscribe from this list: send the line "unsubscribe kvm" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [KVM ARM]     [KVM ia64]     [KVM ppc]     [Virtualization Tools]     [Spice Development]     [Libvirt]     [Libvirt Users]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite Questions]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux