On Thu, Aug 22, 2019 at 01:27:25PM +0000, Singh, Brijesh wrote: > FW accepts the system physical address but the userspace does not know > the system physical instead it will give host virtual address and we > will find its corresponding system physical address and make a FW > call. This is a userspace interface and not the FW. That fact could be in a sentence or two as a comment above the struct definition. > Okay, I will take a look and will probably reuse your functions. thank you. Sure, and pls see if you can simplify the other command-sending functions in a similar manner. Thx. -- Regards/Gruss, Boris. SUSE Linux GmbH, GF: Felix Imendörffer, Mary Higgins, Sri Rasiah, HRB 21284 (AG Nürnberg)