On 22/08/2019 12:03, Andrew Jones wrote: > If after an MMIO exit to userspace a VCPU is immediately run with an > immediate_exit request, such as when a signal is delivered or an MMIO > emulation completion is needed, then the VCPU completes the MMIO > emulation and immediately returns to userspace. As the exit_reason > does not get changed from KVM_EXIT_MMIO in these cases we have to > be careful not to complete the MMIO emulation again, when the VCPU is > eventually run again, because the emulation does an instruction skip > (and doing too many skips would be a waste of guest code :-) We need > to use additional VCPU state to track if the emulation is complete. > As luck would have it, we already have 'mmio_needed', which even > appears to be used in this way by other architectures already. > > Fixes: 0d640732dbeb ("arm64: KVM: Skip MMIO insn after emulation") > Signed-off-by: Andrew Jones <drjones@xxxxxxxxxx> > --- > v2: move mmio_needed use closer to other mmio state use [maz] > > virt/kvm/arm/mmio.c | 7 +++++++ > 1 file changed, 7 insertions(+) Applied with Mark's Ack. Thanks, M. -- Jazz is not dead, it just smells funny...