On Tue, 20 Aug 2019 02:12:10 +0000 "Zhang, Tina" <tina.zhang@xxxxxxxxx> wrote: > BTW, IIRC, we might also have one question waiting to be replied: > - Can we just use VFIO_IRQ_TYPE_GFX w/o proposing a new sub type > (i.e. VFIO_IRQ_SUBTYPE_GFX_DISPLAY_IRQ)? Well, only if we can agree > on that we don't have any other GFX IRQ requirements in future. > Otherwise, we might need a sub type to differentiate them. I think you've answered your own question ;) We already have the infrastructure for defining type/sub-type and it allows us to categorize and group interrupt types together consistent with how we do for regions, so what's the overhead in this approach? Otherwise we tend to have an ad-hoc list. We can't say with absolute certainty that we won't have additional GFX related IRQs. Thanks, Alex
