On Mon, Jul 13, 2009 at 07:42:56PM +0800, Sheng Yang wrote: > On Thursday 09 July 2009 17:00:42 Sheng Yang wrote: > > set_cr3() should already cover the TLB flushing. > > > Comments? Looks good. > > -- > regards > Yang, Sheng > > > Signed-off-by: Sheng Yang <sheng@xxxxxxxxxxxxxxx> > > --- > > arch/x86/kvm/mmu.c | 2 +- > > 1 files changed, 1 insertions(+), 1 deletions(-) > > > > diff --git a/arch/x86/kvm/mmu.c b/arch/x86/kvm/mmu.c > > index 231d880..501c11e 100644 > > --- a/arch/x86/kvm/mmu.c > > +++ b/arch/x86/kvm/mmu.c > > @@ -2349,8 +2349,8 @@ int kvm_mmu_load(struct kvm_vcpu *vcpu) > > spin_unlock(&vcpu->kvm->mmu_lock); > > if (r) > > goto out; > > + /* set_cr3() should ensure TLB has been flushed */ > > kvm_x86_ops->set_cr3(vcpu, vcpu->arch.mmu.root_hpa); > > - kvm_mmu_flush_tlb(vcpu); > > out: > > return r; > > } > -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
