On Mon, Aug 12, 2019 at 03:07:05PM +1000, Paul Mackerras wrote: > lbz r5, VCPU_XIVE_ESC_ON(r9) > cmpwi r5, 0 > - beq 1f > + beq 4f > li r0, 0 > stb r0, VCPU_CEDED(r9) > + li r6, XIVE_ESB_SET_PQ_10 > + b 1f > +4: li r0, 1 > + stb r0, VCPU_XIVE_ESC_ON(r9) This ends up setting vcpu->arch.xive_esc_on even on platforms without XIVE, which is wrong. I'll send a v2. Paul.