On 30/07/19 13:45, Anup Patel wrote: >> so: >> >> 1) indeed we need SP2V=SPV=1 when entering guest mode >> >> 2) sstatus.SPP contains the guest mode >> >> 3) SP2P doesn't really matter for KVM since it never goes to VS-mode >> from an interrupt handler, so if my reasoning is correct I'd leave it >> clear, but I guess it's up to you whether to set it or not. > Yes, SP2P does not matter but we set it to 1 here so that from Guest > perspective it seems we were in S-mode previously. But the guest never reads sstatus.SPP, it always reads, vsstatus.SPP doesn't it? In any case it doesn't matter. Paolo
