On Mon, 2019-07-29 at 22:08 +0200, Paolo Bonzini wrote: > On 29/07/19 21:51, Atish Patra wrote: > > On Mon, 2019-07-29 at 21:40 +0200, Paolo Bonzini wrote: > > > On 29/07/19 13:57, Anup Patel wrote: > > > > + csr_write(CSR_HSTATUS, vcpu->arch.guest_context.hstatus > > > > | > > > > HSTATUS_SPRV); > > > > + csr_write(CSR_SSTATUS, vcpu- > > > > >arch.guest_context.sstatus); > > > > + val = *addr; > > > > > > What happens if this load faults? > > > > > > > It should redirect the trap back to VS mode. Currently, it is not > > implemented. It is on the TO-DO list for future iteration of the > > series. > > Ok, please add TODO comments for the more important tasks like this > one > (and/or post a somewhat complete list in reply to 00/16). > Sure. Will add a TODO comment here and put the complete TODO list in cover letter as well. Regards, Atish > Thanks! > > Paolo >