On Fri, 19 Jul 2019 13:01:30 +0200 Halil Pasic <pasic@xxxxxxxxxxxxx> wrote: > > > diff --git a/arch/s390/include/asm/dma.h b/arch/s390/include/asm/dma.h > > > index 6f26f35d4a71..3b0329665b13 100644 > > > --- a/arch/s390/include/asm/dma.h > > > +++ b/arch/s390/include/asm/dma.h > > > @@ -10,6 +10,7 @@ > > > * by the 31 bit heritage. > > > */ > > > #define MAX_DMA_ADDRESS 0x80000000 > > > +#define ARCH_ZONE_DMA_BITS 31 > > > > powerpc has this in arch/powerpc/include/asm/page.h. This really > > should be consistently defined in the same header file across > > architectures. > > > > Christoph, what is the preferred header file for this definition? ping Christoph could you please answer Heiko's question, so I can do my respin. Regards, Halil > > > > I'd also rather say it would be better to move the #ifndef ARCH_ZONE_DMA_BITS > > check to a common code header file instead of having it in a C file, and > > make it more obvious in which header file architectures should/can override > > the default, no? > > +1 > > I will wait for Christoph's answer with a respin. Thanks for having a > look.
