> On Jul 15, 2019, at 11:54 AM, Paolo Bonzini <pbonzini@xxxxxxxxxx> wrote: > > On 15/07/19 20:43, Nadav Amit wrote: >>> On Jul 15, 2019, at 11:26 AM, Paolo Bonzini <pbonzini@xxxxxxxxxx> wrote: >>> On 15/07/19 20:08, Nadav Amit wrote: >>>>> This works because setup_multiboot() looks for an initrd, and then, >>>>> if present, it gets interpreted as a list of environment variables >>>>> which become the unit tests **envp. >>>> >>>> Looks like a nice solution, but Paolo preferred to see if this information >>>> can be extracted from e810 and ACPI MADT. Paolo? >>> >>> It was mostly a matter of requiring adjustments in the tests. Andrew's >>> solution would be fine! >> >> Ok, but I must be missing something, because the changes I proposed before >> did not require any changes to the tests either (when they are run on top >> of KVM). > > You're right, I was confused. There were changes to a couple tests but > they are not related to fw_cfg. I only disliked having to repeat the > same information (as opposed to just the initrd path) in all the > entries. Memory map and MADT would be my preferred choice, but as a > stopgap Andrew's idea is okay. > > Paolo > >> Andrew’s solution would just make it easier to set “fixed” boot-loader >> entries, although they would still need a different root and >> boot-relative-path on different machines. Paolo, can you please push all (or at my) queued patches? I prefer to work on the latest code (including my patches that were queued), and anyhow kvm-unit-tests repository is broken right now and does not build.
