On 16/07/19 10:49, Wei Wang wrote: > { > KVM_PMU_EVENT_ACTION_GP_NONE = 0, > KVM_PMU_EVENT_ACTION_GP_ACCEPT = 1, > KVM_PMU_EVENT_ACTION_GP_REJECT = 2, > KVM_PMU_EVENT_ACTION_MAX > }; > > and add comments to explain something like below: > > Those GP actions are for the filtering of guest events running on the > virtual general > purpose counters. The actions to filter guest events running on the > virtual fixed > function counters are not added currently as they all seem fine to be > used by the > guest so far, but that could be supported on demand in the future via > adding new > actions. > Let's just implement the bitmap of fixed counters (it's okay to follow the same action as gp counters), and add it to struct kvm_pmu_event_filter. While at it, we can add a bunch of padding u32s and a flags field that can come in handy later (it would fail the ioctl if nonzero). Wei, Eric, who's going to do it? :) Paolo