Re: [PATCH] KVM: nVMX: Ignore segment base for VMX memory operand when segment not FS or GS

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Subject: Re: [PATCH] KVM: nVMX: Ignore segment base for VMX memory operand when segment not FS or GS
From: Paolo Bonzini <pbonzini@xxxxxxxxxx>
Date: Mon, 15 Jul 2019 20:28:49 +0200
Cc: Liran Alon <liran.alon@xxxxxxxxxx>, max@xxxxxxxxxxx, Joao Martins <joao.m.martins@xxxxxxxxxx>, rkrcmar@xxxxxxxxxx, kvm@xxxxxxxxxxxxxxx
In-reply-to: <20190715172139.GB789@linux.intel.com>
Openpgp: preference=signencrypt
References: <20190715154744.36134-1-liran.alon@oracle.com> <87r26rw9lv.fsf@vitty.brq.redhat.com> <20190715172139.GB789@linux.intel.com>
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.7.2

On 15/07/19 19:21, Sean Christopherson wrote:
>>> +		if ((seg_reg != VCPU_SREG_FS) && (seg_reg != VCPU_SREG_GS))
> I'm pretty sure the internal parantheses are unnecessary.
> 

Indeed, that's so Pascal! :)  I'll apply Vitaly's suggestion and queue it.

Paolo

Follow-Ups:
- Re: [PATCH] KVM: nVMX: Ignore segment base for VMX memory operand when segment not FS or GS
  - From: Liran Alon

References:
- [PATCH] KVM: nVMX: Ignore segment base for VMX memory operand when segment not FS or GS
  - From: Liran Alon
- Re: [PATCH] KVM: nVMX: Ignore segment base for VMX memory operand when segment not FS or GS
  - From: Vitaly Kuznetsov
- Re: [PATCH] KVM: nVMX: Ignore segment base for VMX memory operand when segment not FS or GS
  - From: Sean Christopherson

Prev by Date: Re: [kvm-unit-tests PATCH 3/3] x86: Support environments without test-devices
Next by Date: Re: [PATCH] KVM: nVMX: Ignore segment base for VMX memory operand when segment not FS or GS
Previous by thread: Re: [PATCH] KVM: nVMX: Ignore segment base for VMX memory operand when segment not FS or GS
Next by thread: Re: [PATCH] KVM: nVMX: Ignore segment base for VMX memory operand when segment not FS or GS
Index(es):
- Date
- Thread

[Index of Archives] [KVM ARM] [KVM ia64] [KVM ppc] [Virtualization Tools] [Spice Development] [Libvirt] [Libvirt Users] [Linux USB Devel] [Linux Audio Users] [Yosemite Questions] [Linux Kernel] [Linux SCSI] [XFree86]