On 07/08/2009 10:44 PM, Jan Kiszka wrote:
Deferred until v2. My first impression is that too much upstream code is moved or touched. Glauber, if you want to use some function that is currently under KVM_UPSTREAM, don't move it, just drop the #ifdef around it. And when done, have a look at the diff between upstream and qemu-kvm to avoid unneeded variations.
Yes. I though that's what we'd agreed, but forgot to verify it. The only difference should be #endif/#ifdef pairs.
Another question: What prevents using CONFIG_KVM also for qemu-kvm? I would rather mask out yet unused upstream code via the well-known KVM_UPSTREAM and drop the easily confusable USE_KVM defines.
Good idea, would simplify ./configure as well. -- I have a truly marvellous patch that fixes the bug which this signature is too narrow to contain. -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
