On Fri, Jun 21, 2019 at 03:13:20PM -0400, Eric Farman wrote: > Conny, > > I'm bad at things, because I thought for sure I had checked for and > fixed this before I sent the patches. This one gets a sparse warning, > fixed below. > > Eric > > On 6/21/19 10:33 AM, Cornelia Huck wrote: > > From: Eric Farman <farman@xxxxxxxxxxxxx> > > > > This is a really useful function, but it's buried in the > > copy_ccw_from_iova() routine so that ccwchain_calc_length() > > can just work with Format-1 CCWs while doing its counting. > > But it means we're translating a full 2K of "CCWs" to Format-1, > > when in reality there's probably far fewer in that space. > > > > Let's factor it out, so maybe we can do something with it later. > > > > Signed-off-by: Eric Farman <farman@xxxxxxxxxxxxx> > > Message-Id: <20190618202352.39702-5-farman@xxxxxxxxxxxxx> > > Reviewed-by: Cornelia Huck <cohuck@xxxxxxxxxx> > > Reviewed-by: Farhan Ali <alifm@xxxxxxxxxxxxx> > > Signed-off-by: Cornelia Huck <cohuck@xxxxxxxxxx> > > --- > > drivers/s390/cio/vfio_ccw_cp.c | 48 ++++++++++++++++++---------------- > > 1 file changed, 25 insertions(+), 23 deletions(-) > > > > diff --git a/drivers/s390/cio/vfio_ccw_cp.c b/drivers/s390/cio/vfio_ccw_cp.c > > index a55f8d110920..9a8bf06281e0 100644 > > --- a/drivers/s390/cio/vfio_ccw_cp.c > > +++ b/drivers/s390/cio/vfio_ccw_cp.c > > @@ -161,6 +161,27 @@ static inline void pfn_array_idal_create_words( > > idaws[0] += pa->pa_iova & (PAGE_SIZE - 1); > > } > > > > +void convert_ccw0_to_ccw1(struct ccw1 *source, unsigned long len) > > static void convert_... Please send an add-on patch. Code is already in our internal tree for testing purposes and will be push out next week.
