Hi Igor, Thanks for your review. On 2019/6/20 20:10, Igor Mammedov wrote: >> + */ >> +struct AcpiGenericErrorStatus { >> + /* It is a bitmask composed of ACPI_GEBS_xxx macros */ >> + uint32_t block_status; >> + uint32_t raw_data_offset; >> + uint32_t raw_data_length; >> + uint32_t data_length; >> + uint32_t error_severity; >> +} QEMU_PACKED; >> +typedef struct AcpiGenericErrorStatus AcpiGenericErrorStatus; > there shouldn't be packed structures, > is it a leftover from previous version? I remember some people suggest to add QEMU_PACKED before, anyway I will remove it in my next version patch. > >> + >> +/* >> + * Masks for block_status flags above >> + */ >> +#define ACPI_GEBS_UNCORRECTABLE 1 >> + >> +/*