> On 18 Jun 2019, at 11:55, Dr. David Alan Gilbert <dgilbert@xxxxxxxxxx> wrote: > > * Liran Alon (liran.alon@xxxxxxxxxx) wrote: >> Reviewed-by: Nikita Leshenko <nikita.leshchenko@xxxxxxxxxx> >> Reviewed-by: Maran Wilson <maran.wilson@xxxxxxxxxx> >> Signed-off-by: Liran Alon <liran.alon@xxxxxxxxxx> >> --- >> include/migration/vmstate.h | 18 ++++++++++++++++++ >> 1 file changed, 18 insertions(+) >> >> diff --git a/include/migration/vmstate.h b/include/migration/vmstate.h >> index 9224370ed59a..a85424fb0483 100644 >> --- a/include/migration/vmstate.h >> +++ b/include/migration/vmstate.h >> @@ -797,6 +797,15 @@ extern const VMStateInfo vmstate_info_qtailq; >> #define VMSTATE_UINT64_V(_f, _s, _v) \ >> VMSTATE_SINGLE(_f, _s, _v, vmstate_info_uint64, uint64_t) > > A comment here stating they're for Linux kernel types would be nice. I didn’t want to state this because in theory these types can be used not in kernel context… I thought commit message is sufficient. I think comments in code should be made to clarify things. But to justify existence I think commit message should be used. But if you insist, I have no strong objection of adding such comment. > >> +#define VMSTATE_U8_V(_f, _s, _v) \ >> + VMSTATE_SINGLE(_f, _s, _v, vmstate_info_uint8, __u8) >> +#define VMSTATE_U16_V(_f, _s, _v) \ >> + VMSTATE_SINGLE(_f, _s, _v, vmstate_info_uint16, __u16) >> +#define VMSTATE_U32_V(_f, _s, _v) \ >> + VMSTATE_SINGLE(_f, _s, _v, vmstate_info_uint32, __u32) >> +#define VMSTATE_U64_V(_f, _s, _v) \ >> + VMSTATE_SINGLE(_f, _s, _v, vmstate_info_uint64, __u64) >> + > > Have you checked that builds OK on a non-Linux system? Hmm that’s a good point. No. :P -Liran > > Dave > >> #define VMSTATE_BOOL(_f, _s) \ >> VMSTATE_BOOL_V(_f, _s, 0) >> >> @@ -818,6 +827,15 @@ extern const VMStateInfo vmstate_info_qtailq; >> #define VMSTATE_UINT64(_f, _s) \ >> VMSTATE_UINT64_V(_f, _s, 0) >> >> +#define VMSTATE_U8(_f, _s) \ >> + VMSTATE_U8_V(_f, _s, 0) >> +#define VMSTATE_U16(_f, _s) \ >> + VMSTATE_U16_V(_f, _s, 0) >> +#define VMSTATE_U32(_f, _s) \ >> + VMSTATE_U32_V(_f, _s, 0) >> +#define VMSTATE_U64(_f, _s) \ >> + VMSTATE_U64_V(_f, _s, 0) >> + >> #define VMSTATE_UINT8_EQUAL(_f, _s, _err_hint) \ >> VMSTATE_SINGLE_FULL(_f, _s, 0, 0, \ >> vmstate_info_uint8_equal, uint8_t, _err_hint) >> -- >> 2.20.1 >> > -- > Dr. David Alan Gilbert / dgilbert@xxxxxxxxxx / Manchester, UK
