Jim Mattson <jmattson@xxxxxxxxxx> writes: > On Thu, Jun 13, 2019 at 6:55 AM Vitaly Kuznetsov <vkuznets@xxxxxxxxxx> wrote: > >> I can try sending a patch removing the manual advancement to see if >> anyone has any objections. > > That would be great! > Turns out this is harder than I initially thought, in the emulator we don't emulate everything (e.g. XSETVB) and emulating some instructions (even with EMULTYPE_SKIP) gives us some unintended side-effects, e.g. I'm currently observing a hang when trying to apply kvm_emulate_instruction() to HLT. Overall, I still think this is the right approach, we just need to make EMULTYPE_SKIP skip correctly. Stay tuned... -- Vitaly
