On Fri, Jun 07, 2019 at 05:17:09PM +0200, Paolo Bonzini wrote: > On 07/06/19 16:18, Sean Christopherson wrote: > > On Fri, Jun 07, 2019 at 02:19:20PM +0200, Paolo Bonzini wrote: > >> On 06/06/19 20:41, Sean Christopherson wrote: > >>>> +static void prepare_vmcs02_early_extra(struct vcpu_vmx *vmx, > >>> Or maybe 'uncommon', 'rare' or 'ext'? I don't I particularly love any of > >>> the names, but they're all better than 'full'. > >> > >> I thought 'ext' was short for 'extra'? :) > > > > Ha, I (obviously) didn't make that connection. ext == extended in my mind. > > That's what came to mind first, but then "extended" had the same issue > as "full" (i.e. encompassing the "basic" set as well) so I decided you > knew better! Ah, I was thinking of "basic" and "extended" as separate states, but your interpretation is correct. I probably have a slight preference for 'uncommon' over 'extra'? I feel like they have equal odds of being misinterpreted, so pick your poison :-)