On Thu, Jun 06, 2019 at 03:02:02PM +0200, Paolo Bonzini wrote: > On 20/04/19 07:50, Sean Christopherson wrote: > > Generic x86 code blindly invokes the dedicated external interrupt > > handler blindly, i.e. vmx_handle_external_intr() is called on all > > VM-Exits regardless of the actual exit type. > > That's *really* blindly. :) Rephrased to Hmm, I must not have seen the first one. > Generic x86 code invokes the kvm_x86_ops external interrupt handler > on all VM-Exits regardless of the actual exit type. > > - unsigned long entry; > - gate_desc *desc; > + unsigned long entry; > > I'd rather keep the desc variable to simplify review (with "diff -b") > and because the code is more readable that way. Unless you have a > strong reason not to do so, I can do the change when applying. No strong reason, I found the code to be more readable without it :-)
