On Wed, 29 May 2019 22:11:06 +0200 "Thomas Meyer" <thomas@xxxxxxxx> wrote: > Use vma_pages function on vma object instead of explicit computation. > > Signed-off-by: Thomas Meyer <thomas@xxxxxxxx> > --- > > diff -u -p a/drivers/vfio/pci/vfio_pci_nvlink2.c b/drivers/vfio/pci/vfio_pci_nvlink2.c > --- a/drivers/vfio/pci/vfio_pci_nvlink2.c > +++ b/drivers/vfio/pci/vfio_pci_nvlink2.c > @@ -161,7 +161,7 @@ static int vfio_pci_nvgpu_mmap(struct vf > > atomic_inc(&data->mm->mm_count); > ret = (int) mm_iommu_newdev(data->mm, data->useraddr, > - (vma->vm_end - vma->vm_start) >> PAGE_SHIFT, > + vma_pages(vma), > data->gpu_hpa, &data->mem); > > trace_vfio_pci_nvgpu_mmap(vdev->pdev, data->gpu_hpa, data->useraddr, Not sure if our emails crossed in flight[1], but the other patch[2] still has precedence. You're welcome to add a reviewed-by. Thanks, Alex [1]https://lkml.org/lkml/2019/5/29/871 [2]https://lkml.org/lkml/2019/5/16/658