On Mon, May 20, 2019 at 02:38:44PM +0800, Wanpeng Li wrote: > On Sat, 18 May 2019 at 03:44, Sean Christopherson > <sean.j.christopherson@xxxxxxxxx> wrote: > > This needs to be guarded with lapic_in_kernel(vcpu). But, since this is > > all in the same flow, a better approach would be to return the delta from > > wait_lapic_expire(). That saves 8 bytes in struct kvm_timer and avoids > > additional checks for tracing the delta. > > As you know, the function wait_lapic_expire() will be moved to vmx.c > and svm.c, so this is not suitable any more. Doh, I was too excited about my cleverness and completely forgot why you were moving the tracepoint in the first place.
