On 15/05/19 23:40, Liran Alon wrote: > >> On 16 May 2019, at 0:35, Paolo Bonzini <pbonzini@xxxxxxxxxx> >> wrote: >> >> After KVM commit 672ff6cff80ca43bf3258410d2b887036969df5f, reading >> a VMware pseudo PMC will fail with #GP unless the PMU is supported >> by the guest. Invoke the test with PMU emulation to ensure that it >> passes. >> >> Signed-off-by: Paolo Bonzini <pbonzini@xxxxxxxxxx> > > Reviewed-by: Liran Alon <liran.alon@xxxxxxxxxx> > I think it will also > be more intuitive if in addition, we will check in the kvm-unit-test > itself the CPUID such that we will skip test in case PMU is not > exposed by vCPU. Yes, good idea. Paolo
