On 15/05/2019 14:06, Auger Eric wrote: > Hi Jean-Philippe, > > On 5/15/19 2:09 PM, Jean-Philippe Brucker wrote: >> On 08/04/2019 13:18, Eric Auger wrote: >>> diff --git a/include/uapi/linux/iommu.h b/include/uapi/linux/iommu.h >>> index edcc0dda7993..532a64075f23 100644 >>> --- a/include/uapi/linux/iommu.h >>> +++ b/include/uapi/linux/iommu.h >>> @@ -112,4 +112,51 @@ struct iommu_fault { >>> struct iommu_fault_page_request prm; >>> }; >>> }; >>> + >>> +/** >>> + * SMMUv3 Stream Table Entry stage 1 related information >>> + * The PASID table is referred to as the context descriptor (CD) table. >>> + * >>> + * @s1fmt: STE s1fmt (format of the CD table: single CD, linear table >>> + or 2-level table) >> >> Running "scripts/kernel-doc -v -none" on this header produces some >> warnings. Not sure if we want to get rid of all of them, but we should >> at least fix the coding style for this comment (line must start with >> " * "). I'm fixing it up on my sva/api branch > Thanks! > > Let me know if you want me to do the job for additional fixes. I fixed the others warnings as well, in case we ever want to include this into the kernel doc Thanks, Jean