Re: [KVM nVMX]: Check "load IA32_PERF_GLOBAL_CTRL" on vmentry of nested guests

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Apr 24, 2019 at 07:17:16PM -0400, Krish Sadhukhan wrote:
> Patch 1 through 7 add the necessary KVM code for checking and enabling
> "load IA32_PERF_GLOBAL_CTRL" VM-{exit,entry} controls.
> 
> Patch# 8 adds a unit test for the "load IA32_PERF_GLOBAL_CTRL" VM-exit
> control. I will send a separate patch for the unit test for
> "load IA32_PERF_GLOBAL_CTRL" VM-entry control.
> 
> 
> [PATCH 1/8][KVMnVMX]: Enable "load IA32_PERF_GLOBAL_CTRL" VM-exit control
> [PATCH 2/8][KVM nVMX]: Enable "load IA32_PERF_GLOBAL_CTRL" VM-entry
> [PATCH 3/8][KVM VMX]: Add a function to check reserved bits in
> [PATCH 4/8][KVM nVMX]: Check "load IA32_PERF_GLOBAL_CTRL" VM-exit control
> [PATCH 5/8][KVM nVMX]: Check "load IA32_PERF_GLOBAL_CTRL" VM-entry control
> [PATCH 6/8][KVM nVMX]: Load IA32_PERF_GLOBAL_CTRL MSR on vmentry of nested
> [PATCH 7/8][KVM nVMX]: Enable "load IA32_PERF_GLOBAL_CTRL VM-{entry,exit}
> [PATCH 8/8][KVM nVMX]: Test "load IA32_PERF_GLOBAL_CTRL" controls on vmentry

These subjects are wrong, should be:

  [PATCH n/8] KVM: nVMX: Blah blah blah

or something along those lines.  Wrapping the scope in square braces causes
the scope to be dropped when the patch is applied.  They're also different
from the diffstat, which is odd.

And nearly all of the patches are missing proper changelogs.

> 
>  arch/x86/include/asm/kvm_host.h  |  1 +
>  arch/x86/include/asm/msr-index.h |  7 +++++++
>  arch/x86/kvm/vmx/nested.c        | 19 +++++++++++++++++--
>  arch/x86/kvm/vmx/vmx.c           | 12 ++++++++++++
>  arch/x86/kvm/x86.c               | 20 ++++++++++++++++++++
>  5 files changed, 57 insertions(+), 2 deletions(-)
> 
> Krish Sadhukhan (7):
>       nVMX: Enable "load IA32_PERF_GLOBAL_CTRL" VM-exit control for nested guests
>       nVMX: Enable "load IA32_PERF_GLOBAL_CTRL" VM-entry control for nested guests
>       VMX: Add a function to check reserved bits in MSR_CORE_PERF_GLOBAL_CTRL
>       nVMX: Check "load IA32_PERF_GLOBAL_CTRL" VM-exit control on vmentry of nested guests
>       nVMX: Check "load IA32_PERF_GLOBAL_CTRL" VM-entry control on vmentry of nested guests
>       nVMX: Load IA32_PERF_GLOBAL_CTRL MSR on vmentry of nested guests
>       nVMX: Enable "load IA32_PERF_GLOBAL_CTRL VM-{entry,exit} controls
> 
>  x86/vmx_tests.c | 59 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++
>  1 file changed, 59 insertions(+)
> 
> Krish Sadhukhan (1):
>       nVMX: Test "load IA32_PERF_GLOBAL_CTRL" controls on vmentry of nested guests
> 



[Index of Archives]     [KVM ARM]     [KVM ia64]     [KVM ppc]     [Virtualization Tools]     [Spice Development]     [Libvirt]     [Libvirt Users]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite Questions]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux