> On May 8, 2019, at 4:21 PM, Jim Mattson <jmattson@xxxxxxxxxx> wrote: > > From: Nadav Amit <nadav.amit@xxxxxxxxx> > Date: Wed, May 8, 2019 at 10:47 AM > To: Paolo Bonzini > Cc: <kvm@xxxxxxxxxxxxxxx>, Nadav Amit, Jim Mattson, Sean Christopherson > >> From: Nadav Amit <nadav.amit@xxxxxxxxx> >> >> Intel SDM 26.6.5 says regarding interrupt-window exiting that: "These >> events wake the logical processor if it just entered the HLT state >> because of a VM entry." A similar statement is told about NMI-window >> exiting. >> >> However, running tests which are similar to verify_nmi_window_exit() and >> verify_intr_window_exit() on bare-metal suggests that real CPUs do not >> wake up. Until someone figures what the correct behavior is, just reset >> the activity state to "active" after each test to prevent the whole >> test-suite from getting stuck. >> >> Cc: Jim Mattson <jmattson@xxxxxxxxxx> >> Cc: Sean Christopherson <sean.j.christopherson@xxxxxxxxx> >> Signed-off-by: Nadav Amit <nadav.amit@xxxxxxxxx> > Reviewed-by: Jim Mattson <jmattson@xxxxxxxxxx> > > I think I have been assuming that "wake the logical processor" means > "causes the logical processor to enter the 'active' activity state." > Maybe that's not what "wake" means? I really don’t know. Reading the specifications, I thought that the test is valid. I don’t manage to read it any differently than you did.
