On Wed, May 08, 2019 at 08:52:25PM +0000, Jacob Pan wrote:
> On Wed, 8 May 2019 09:58:30 -0700
> Christoph Hellwig <hch@xxxxxxxxxxxxx> wrote:
>
> > On Wed, May 08, 2019 at 05:44:12PM +0300, Kirill A. Shutemov wrote:
> > > +EXPORT_SYMBOL_GPL(__mem_encrypt_dma_set);
> > > +
> > > +phys_addr_t __mem_encrypt_dma_clear(phys_addr_t paddr)
> > > +{
> > > + if (sme_active())
> > > + return __sme_clr(paddr);
> > > +
> > > + return paddr & ~mktme_keyid_mask;
> > > +}
> > > +EXPORT_SYMBOL_GPL(__mem_encrypt_dma_clear);
> >
> > In general nothing related to low-level dma address should ever
> > be exposed to modules. What is your intended user for these two?
>
> Right no need to export. It will be used by IOMMU drivers.
I will drop these EXPORT_SYMBOL_GPL().
--
Kirill A. Shutemov
