On 08/05/19 04:15, Peter Xu wrote: > The previous KVM_CAP_MANUAL_DIRTY_LOG_PROTECT has some problem which > blocks the correct usage from userspace. Obsolete the old one and > introduce a new capability bit for it. > > Signed-off-by: Peter Xu <peterx@xxxxxxxxxx> > --- I renamed it to KVM_CAP_MANUAL_DIRTY_LOG_PROTECT2. Also, this paragraph +The old name of KVM_CAP_MANUAL_DIRTY_LOG_PROTECT_2 is +KVM_CAP_MANUAL_DIRTY_LOG_PROTECT but it was obsolete now. should be under the description of the capability, and perhaps can be expanded like this: +KVM_CAP_MANUAL_DIRTY_LOG_PROTECT2 was previously available under the name +KVM_CAP_MANUAL_DIRTY_LOG_PROTECT, but the implementation had bugs that make +it hard or impossible to use it correctly. The availability of +KVM_CAP_MANUAL_DIRTY_LOG_PROTECT2 signals that those bugs are fixed. +Userspace should not try to use KVM_CAP_MANUAL_DIRTY_LOG_PROTECT. No need to do anything on your part. Paolo
