On Wed, May 08, 2019 at 10:12:49AM +0200, Paolo Bonzini wrote: > On 08/05/19 00:44, Peter Xu wrote: > > Two issues I've noticed when I'm drafting the QEMU support of it. > > With these two patches applied the QEMU binary (with the clear dirty > > log supported [1]) can migrate correctly otherwise the migration can > > stall forever if with/after heavy memory workload. > > > > Please have a look, thanks. > > > > [1] https://github.com/xzpeter/qemu/tree/kvm-clear-dirty-log > > > > Peter Xu (2): > > kvm: Fix the bitmap range to copy during clear dirty > > kvm: Fix loop of clear dirty with off-by-one > > > > virt/kvm/kvm_main.c | 6 +++--- > > 1 file changed, 3 insertions(+), 3 deletions(-) > > > > Looks good, but this is a blocker for using this feature in userspace. > I think we should change the capability name and number. Ok, let me add another patch for it. Also I probably have made a mistake too in patch 2 (it's not really off-by-one, but it should be a DIV_ROUND_UP I think...). I'll post a new version soon. Thanks, -- Peter Xu
