On 30/04/19 19:36, Sean Christopherson wrote: > ... to prevent future code from using the unoptimized generic accessors > when hardcoding access to always-available GPRs. This cannot be done in general, because builtin_constant_p could be used through layers of inlining. For example you could have a function that takes an enum kvm_reg argument and _its_ caller passes a constant in there. Of course we may just say that we don't have such a case now (do we?) and so it's unlikely to happen in the future as well. Paolo
