On 18.04.19 12:40, Christian Borntraeger wrote: >> >> If you don't glue this to KVM_S390_VM_CRYPTO_ENABLE_AES_KW, you will >> have to find another way to reset AES keys during resets. > > I think it is better to add 2 new attributes as we can have pckmo for ecc but > not for aes (e.g. ECB3_AES == 0 but ECD_ECC ==1). On the other hand: MSA9 requires MSA3 and MSA4 to be present. So simply checking for kvm->arch.crypto.aes_kw ==1 as you suggested is very likely good enough.