On Fri, Apr 12, 2019 at 10:30:51AM +0200, Paolo Bonzini wrote: > On 11/04/19 21:18, Sean Christopherson wrote: > > Convert all top-level nested VM-Enter consistency check functions to > > use explicit parameters to pass failure information to the caller. > > Using an explicit parameter achieves several goals: > > > > - Provides consistent prototypes for all functions. > > - Self-documents the net effect of failure, e.g. without the explicit > > parameter it may not be obvious that nested_vmx_check_guest_state() > > leads to a VM-Exit. > > - Does not give the false impression that failure information is > > always consumed and/or relevant, e.g. vmx_set_nested_state() only > > cares whether or not the checks were successful. > > > > Suggested-by: Paolo Bonzini <pbonzini@xxxxxxxxxx> > > Signed-off-by: Sean Christopherson <sean.j.christopherson@xxxxxxxxx> > > --- > > I think we have to agree to disagree on this one. :) Aaargh! The dreaded Maintainer Hammer of Doom! LGTM ;-)
