On Wed, Apr 10, 2019 at 11:19:19AM +0200, Paolo Bonzini wrote: > On 02/04/19 17:03, Sean Christopherson wrote: > > Ostensibly, the only motivation for having HF_SMM_MASK set throughout > > the loading of state from the SMRAM save state area is so that the > > memory accesses from GET_SMSTATE() are tagged with role.smm (though > > arguably even that is unnecessary). > > Why is that unnecessary? If they do not have role.smm they would access > video RAM or TSEG, not the state save area. You're right, feel free to strike that line from the record. For some reason I had it in my mind that enter_smm() was writing SMRAM before setting HF_SMM_MASK.
