On Tue, 26 Mar 2019 22:45:42 -0500 Parav Pandit <parav@xxxxxxxxxxxx> wrote: > Instead of masking return error to -EBUSY, return actual error > returned by the driver. > > Reviewed-by: Maxim Levitsky <mlevitsk@xxxxxxxxxx> > Signed-off-by: Parav Pandit <parav@xxxxxxxxxxxx> > --- > drivers/vfio/mdev/mdev_core.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/vfio/mdev/mdev_core.c b/drivers/vfio/mdev/mdev_core.c > index 00ca613..836d319 100644 > --- a/drivers/vfio/mdev/mdev_core.c > +++ b/drivers/vfio/mdev/mdev_core.c > @@ -141,7 +141,7 @@ static int mdev_device_remove_ops(struct mdev_device *mdev, bool force_remove) > */ > ret = parent->ops->remove(mdev); > if (ret && !force_remove) > - return -EBUSY; > + return ret; > > sysfs_remove_groups(&mdev->dev.kobj, parent->ops->mdev_attr_groups); > return 0; Makes sense, even if no current ->remove callback returns anything other than 0 or -EBUSY. Reviewed-by: Cornelia Huck <cohuck@xxxxxxxxxx>
