On Fri, Mar 15, 2019 at 11:15 AM Paolo Bonzini <pbonzini@xxxxxxxxxx> wrote:
>
> On 14/03/19 19:45, Sean Christopherson wrote:
> >>> if (unlikely(vmx->fail)) {
> >>> - pr_info_ratelimited("%s failed vm entry %x\n", __func__,
> >>> - vmcs_read32(VM_INSTRUCTION_ERROR));
> >> I *love* the tracing, but I don't think we want to turn it on for
> >> production. Can we keep the pr_info_ratelimited for when tracing is
> >> disabled?
> > Could we drop it to pr_debug_ratelimited()? Say "no" if it's at all
> > inconvenient to use debug instead of info. The printing is nothing
> > more than a minor annoyance when I'm running unit tests, i.e. any kind
> > of actual use case trumps my partiality for a clean kernel log.
> >
>
> I agree, it should be pr_debug_ratelimited (if anything).
Let's go ahead and drop it, then.
